[Webkit-unassigned] [Bug 102122] [EFL][WK2] New window size should consult the window attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102122





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-13 13:35:59 PST ---
(From update of attachment 173962)
View in context: https://bugs.webkit.org/attachment.cgi?id=173962&action=review

Nice!

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:841
> +    WKRetainPtr<WKStringRef> widthStr(AdoptWK, WKStringCreateWithUTF8CString("width"));
> +    WKRetainPtr<WKStringRef> heightStr(AdoptWK, WKStringCreateWithUTF8CString("height"));
> +

Maybe a comment that we don't do everything here? for showModalDialog are they also called width and height or dialogWidth etc?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:842
> +    int width = 0;

unsigned?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:846
> +    if (ref)
> +        width = WKDoubleGetValue(static_cast<WKDoubleRef>(ref));

unsigned width = ref ? WKDoubleGetValue(static_cast<WKDoubleRef>(ref)) : 0 ?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:852
> +    width = std::max(width, 0);
> +    height = std::max(height, 0);

WebKit makes sure these are always bigger than 100px. You could assert

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.