[Webkit-unassigned] [Bug 102000] [EFL][WK2] White flicker when scrolling big pages with dark background on slower hardware.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102000





--- Comment #17 from Noam Rosenthal <noam at webkit.org>  2012-11-13 13:13:54 PST ---
(From update of attachment 173936)
View in context: https://bugs.webkit.org/attachment.cgi?id=173936&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2776
> +    if (m_drawingArea && m_drawingArea->layerTreeHost()) {
> +        double red, green, blue, alpha;
> +        m_mainFrame->getDocumentBackgroundColor(&red, &green, &blue, &alpha);
> +        RGBA32 rgba = makeRGBA32FromFloats(red, green, blue, alpha);
> +        if (m_backgroundColor.rgb() != rgba) {
> +            m_backgroundColor.setRGB(rgba);
> +            m_drawingArea->layerTreeHost()->setBackgroundColor(m_backgroundColor);
> +        }
> +    }

This should be guarded with ACCELERATED_COMPOSITING, or alternatively it should move to a DrawingArea[Proxy] message set rather than go via coordinated graphics.
I'm ok with this in general but I'm not comfortable r+ing it because I'm not sure of the implication of calling getDocumentBackgroundColor after every layout.
I'm OK with the changes to TextureMapper, if you want to post them in a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.