[Webkit-unassigned] [Bug 101192] [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101192





--- Comment #14 from Mihai Maerean <mmaerean at adobe.com>  2012-11-13 09:57:44 PST ---
(In reply to comment #13)
> > The idea was to use switches::kEnableExperimentalWebKitFeatures in a way that is similar to how it has been used before.
> 
> That's fine, but then you shouldn't use WebCore::Settings.  The problem is that you're trying to use two different mechanisms to control whether the feature is enabled.  You need to pick one and use that.

We are forced to use WebRuntimeFeatures and RuntimeEnabledFeatures in order to stop the feature from leaking information at run-time by adding V8EnabledAtRuntime=cssRegions in the IDL files.

On the other hand, we are forced to use the bit in Settings so that the JSC platforms build the code (so people don't accidentally break it) and also keep the feature disabled at run-time.

So we can't remove any on them.

The solution that I see is to have them both and hopefully the 2 variables won't get out of sync as the webkit/chromium code evolves over time.

Is this acceptable?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.