[Webkit-unassigned] [Bug 101192] [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101192





--- Comment #13 from Adam Barth <abarth at webkit.org>  2012-11-13 08:21:53 PST ---
> The idea was to use switches::kEnableExperimentalWebKitFeatures in a way that is similar to how it has been used before.

That's fine, but then you shouldn't use WebCore::Settings.  The problem is that you're trying to use two different mechanisms to control whether the feature is enabled.  You need to pick one and use that.

> How should I get access to WebSettings from inside render_thread_impl.cc?

You can't.  WebSettings is a per WebView concept.  render_thread_impl is shared across all the WebViews in a given process.  Try grepping around for uses of WebSettings in Chromium and you'll see how to do it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.