[Webkit-unassigned] [Bug 101516] Handle gesture events on scrollbars.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101516


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172881|review?                     |review-
               Flag|                            |




--- Comment #3 from Antonio Gomes <tonikitoo at webkit.org>  2012-11-13 07:12:16 PST ---
(From update of attachment 172881)
View in context: https://bugs.webkit.org/attachment.cgi?id=172881&action=review

Looks generally good. Some requests for a final round.

> Source/WebCore/ChangeLog:10
> +        Handle gesture events on scrollbars.
> +        https://bugs.webkit.org/show_bug.cgi?id=101516
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: fast/events/touch/gesture/gesture-scrollbar.html
> +
> +        * page/EventHandler.cpp:

Please improve your changelog with some more details about motivation, advantages, etc of your change.

> Source/WebCore/page/EventHandler.cpp:387
> +    m_scrollGestureHandlingScrollbar = 0;

I think it would read better a m_scrollbarHandlingScrollGesture .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.