[Webkit-unassigned] [Bug 102060] Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102060





--- Comment #2 from Zoltan Herczeg <zherczeg at webkit.org>  2012-11-13 02:49:05 PST ---
(From update of attachment 173853)
Nice job, just a minor comment:

View in context: https://bugs.webkit.org/attachment.cgi?id=173853&action=review

> Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h:84
> +    uint8x8_t constant1 = vdup_n_u8(0x7);
> +    uint8x8_t constant2 = vdup_n_u8(0xFF);
> +    uint16x8_t constant3 = vdupq_n_u16(0x1F);
> +    uint16x8_t constant4 = vdupq_n_u16(0x1);

These indexes are not nice. I would prefer immediate0x7, immediate0xff, ....

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.