[Webkit-unassigned] [Bug 101978] Web Inspector: Fix docking behaviour on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101978


Brian Weinstein <bweinstein at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173746|review?                     |review+
               Flag|                            |




--- Comment #6 from Brian Weinstein <bweinstein at apple.com>  2012-11-12 16:06:46 PST ---
(From update of attachment 173746)
View in context: https://bugs.webkit.org/attachment.cgi?id=173746&action=review

> Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:143
> +    // Call setDockingUnavailable before bringToFront. If we display the inspector window via bringToFront first it causes the call to canAttachWindow to return the wrong result.

Another sentence on why this is the case would be helpful.

> Source/WebKit/win/ChangeLog:15
> +        (WebInspectorFrontendClient::frontendLoaded):
> +        (WebInspectorFrontendClient::attachWindow):

A high level comment about the changes in these functions would nice for people reading the ChangeLog later.

> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:299
> +    // Immediately after calling showWindowWithoutNotifications(), the parent frameview's visibleHeight incorrectly returns 0 always.

Is this a WebKit bug or a Windows bug?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.