[Webkit-unassigned] [Bug 101563] Add support for fractional scroll events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101563


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173584|review?                     |review-
               Flag|                            |




--- Comment #19 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-11-12 09:02:24 PST ---
(From update of attachment 173584)
View in context: https://bugs.webkit.org/attachment.cgi?id=173584&action=review

> Source/WebCore/platform/ScrollAnimatorNone.h:105
> +#if PLATFORM(CHROMIUM)
>      virtual void scrollBy(const IntPoint&);
> +#else
> +    virtual void scrollBy(const FloatPoint&);
> +#endif

Platform #ifdefs like this in shared files are not cool. You should change everyone to FloatPoint, or no-one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.