[Webkit-unassigned] [Bug 101748] [EFL] Share WebKit2-GTK's Accessibility implementation with other WebKit ports.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 07:09:49 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101748


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-11-12 07:11:31 PST ---
Attachment 173293 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.h:26:  #ifndef header guard has wrong style, please use: WebPageAccessibilityObjectAtk_h  [build/header_guard] [5]
Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.h:56:  web_page_accessibility_object_get_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:107:  web_page_accessibility_object_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:111:  web_page_accessibility_object_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list