[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173334|review?                     |review+
               Flag|                            |




--- Comment #51 from Gustavo Noronha (kov) <gns at gnome.org>  2012-11-12 05:39:56 PST ---
(From update of attachment 173334)
View in context: https://bugs.webkit.org/attachment.cgi?id=173334&action=review

> Source/WebKit2/UIProcess/InspectorServer/WebSocketServerConnection.cpp:82
> -    // If this ASSERT happens on any platform then their SocketStreamHandle::send
> -    // followed by a SocketStreamHandle::close is not guarenteed to have sent all
> -    // data. If this happens, we need to slightly change the design to include a
> -    // SocketStreamHandleClient::didSend, handle it here, and add an m_shutdownAfterSend
> -    // state on this WebSocketServerConnection.
> -    ASSERT(!m_socket->bufferedAmount());
> +    if (m_socket->bufferedAmount()) {
> +        m_shutdownAfterSend = true;
> +        return;
> +    }

The only concern I still have is this, since the comment has not been fully applied, I'm not 100% sure this is acting as expected. If you could double-check with the person who wrote the comment that would be great, otherwise looks fine to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.