[Webkit-unassigned] [Bug 101889] Enable calendar picker for input types datetime/datetime-local

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 01:00:33 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101889





--- Comment #4 from Kent Tamura <tkent at chromium.org>  2012-11-12 01:02:15 PST ---
(From update of attachment 173568)
View in context: https://bugs.webkit.org/attachment.cgi?id=173568&action=review

>>> Source/WebCore/html/shadow/DateTimeEditElement.cpp:498
>>> +    setValueAsDateTimeFieldsState(dateTimeFieldsState);
>> 
>> Can you avoid to change the setValueAsDateTimeFieldsState signature?
>> I think passing a DateComponents for the old value as dateForReadOnlyField argument works well though I'm not 100% sure.
> 
> Hmm, It won't work if there is a read-only field and fields has empty values.

The logic same as BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue should work.
i.e. Use the previous value for dateForReadOnlyField if it's not empty, otherwise use StepRange::minimum().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list