[Webkit-unassigned] [Bug 101688] [EFL][WK2] Add ewk_settings_offline_web_application_cache_enabled set/get API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101688





--- Comment #3 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-10 08:10:52 PST ---
(From update of attachment 173188)
View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review

> Source/WebKit2/ChangeLog:7
> +

The following may be clearer and more correct: "Add API functions to Ewk_Settings to set / get the offline Web application cache enabled state. This setting is now enabled by default for WebKit2 EFL port."

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:353
> + * @param settings settings object to set the offline application cache

... to set the offline application cache state. "state" is missing.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:362
> +* Returns whether the offline application cache is enabled or not.

star alignment problem?

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:367
> + *         @c EINA_FALSE if not or on failure

"if disabled" would be better than "if not" I believe.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:189
> +

Please add a test to make sure the setting is set to true by default.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.