[Webkit-unassigned] [Bug 101800] Correct scroll adjustment for touchEvent.clientX/clientY

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 15:02:04 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101800





--- Comment #3 from Tien-Ren Chen <trchen at chromium.org>  2012-11-09 15:03:42 PST ---
(In reply to comment #2)
> (From update of attachment 173373 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173373&action=review
> 
> > LayoutTests/fast/events/touch/touch-scaled-scrolled.html:17
> > +    if (window.internals) {
> > +        window.internals.settings.setPageScaleFactor(2, 0, 0);
> > +    }
> 
> No need for { } here.
> 
> > LayoutTests/fast/events/touch/touch-scaled-scrolled.html:30
> > +        window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);
> 
> Why do we need to use setTimeout?  Can't we call notifyDone from inside touched?

Copy & paste from other test without much thoughts. Will fix the nits. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list