[Webkit-unassigned] [Bug 99660] checkbox to toggle FPS counter in the inspector's settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99660


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173319|commit-queue?, review?      |review-
               Flag|                            |




--- Comment #46 from Pavel Feldman <pfeldman at chromium.org>  2012-11-09 13:30:12 PST ---
(From update of attachment 173319)
View in context: https://bugs.webkit.org/attachment.cgi?id=173319&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:721
> +    m_client->setShowFPSCounter(show);

Ok, now that I look at it, I can see that there are two important pieces missing. Sorry for not spotting them earlier:

1) You need to m_client->setShowFPSCounter(false) from disable(ErrorString).
It is necessary to remove the FPS counter when inspector is closed. No inspector settings should affect running page when inspector is closed.

2) You need to store enabled state in the m_state via m_state->setBoolean(PageAgentState::showFPSCounter, show) here. 
Then, in enable(ErrorString) you should check it via m_state->getBoolean and in case it is true, you should m_client->setShowFPSCounter(true);

This code path will be used in case when navigation changes renderer process. You basically store your settings in the m_state cookie that is then passed into the restore of the other renderer renderer. 

You can follow the setScriptExecutionDisabled and mimic its behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.