[Webkit-unassigned] [Bug 85343] Cursor change fires mousemove event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85343





--- Comment #6 from Rick Byers <rbyers at chromium.org>  2012-11-09 11:02:08 PST ---
(From update of attachment 173305)
View in context: https://bugs.webkit.org/attachment.cgi?id=173305&action=review

> Source/WebCore/page/EventHandler.cpp:146
> +const double updateMouseCursorInterval = 0.05;

Are you sure a timer is necessary in this case?  I think fake mouse move codepath has a timer for scrolling where there are lots of updates in a row.  If we're getting lots of style updates in a row then I'd guess that there's already a performance problem and mouse cursors might be the least of the concerns.  But I guess this is the safer approach without more performance data.  But it's a shame to add this complexity if it's not really adding value.

> Source/WebCore/page/EventHandler.cpp:1364
> +    ASSERT_UNUSED(timer, timer == &m_updateMouseCursorTimer);

This function shares a lot of code with fakeMouseMoveTimerFired.  We should probably refactor to share common code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.