[Webkit-unassigned] [Bug 101655] [BlackBerry] Adding a sound to touch events on anchor elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101655





--- Comment #3 from otcheung at rim.com  2012-11-09 09:00:03 PST ---
(From update of attachment 173138)
View in context: https://bugs.webkit.org/attachment.cgi?id=173138&action=review

Hi Antonio! We tried playing the audio when we receive a mouseup event, but the problem is the delay we get from the timer in recognizing tap sequence is preventing instant feedback. That's why we need to trigger the sound manually when we get a valid click event in libwebview.

>> Source/WebKit/blackberry/Api/WebPage.h:159
>> +    void playSoundOnAnchorElementTouchEvents();
> 
> bad naming imo
> 
> something around "play sound if anchor is the target" would read better

agreed. playSoundIfAnchorIsTarget sounds better

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.