[Webkit-unassigned] [Bug 101740] [Qt][ARM]REGRESSION(r133985): It broke the build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 06:28:42 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101740





--- Comment #4 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-11-09 06:30:19 PST ---
(In reply to comment #3)
> (From update of attachment 173294 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173294&action=review
> 
> > Source/JavaScriptCore/jit/JITPropertyAccess.cpp:355
> > -template<IndexingType indexingShape>
> > -JIT::JumpList JIT::emitGenericContiguousPutByVal(Instruction* currentInstruction, PatchableJump& badType)
> > +JIT::JumpList JIT::emitGenericContiguousPutByVal(Instruction* currentInstruction, PatchableJump& badType, IndexingType indexingShape)
> 
> I think the goal if it being a template is to generate a faster implementation, i.e. indexingShape is a compile time constant instead of a variable at run-time that's on the stack.
> 
> So I don't think it should become a regular method.

I know the reason, but: 
"""Because templates are compiled when required, this forces a restriction for multi-file projects: the implementation (definition) of a template class or function must be in the same file as its declaration. That means that we cannot separate the interface in a separate header file, and that we must include both interface and implementation in any file that uses the templates."""

and also the GetByVal counterpart is implemented almost in the same way (and not with templates).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list