[Webkit-unassigned] [Bug 99578] [EFL] Share WebKit-Gtk's Accessibility implementation with others WebKit ports.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 01:09:49 PST 2012


--- Comment #18 from Krzysztof Czech <k.czech at samsung.com>  2012-11-09 01:11:24 PST ---
> Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:582
> +    notImplemented()

Missing semicolon.

> Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:592
> +    notImplemented()

Missing semicolon.

> Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:246
> +#endif // PLATFORM(GTK)

Compilation error on other platforms.
Should be moved two lines forward.

> Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:248
>          }

#endif // PLATFORM(GTK)
Should be placed here.

Would like me to continue this bug ?. I think it can be already shipped to mainstream. I found only some minor mistakes

Patches do not make any problems on GTK regarding a11y layout tests.
Results are the same before and after the change.

Found 157 tests; running 138, skipping 19.
All 138 tests run as expected.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list