[Webkit-unassigned] [Bug 101655] [BlackBerry] Adding a sound to touch events on anchor elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 18:33:55 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101655


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173138|review?                     |review-
               Flag|                            |




--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2012-11-08 18:35:32 PST ---
(From update of attachment 173138)
View in context: https://bugs.webkit.org/attachment.cgi?id=173138&action=review

why instead of the client calling this Api, why not make TouchEventHandler to do it on single touch/mouse up?

> Source/WebKit/blackberry/Api/WebPage.h:159
> +    void playSoundOnAnchorElementTouchEvents();

bad naming imo

something around "play sound if anchor is the target" would read better

> Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:187
> +void TouchEventHandler::playSoundOnAnchorElementTouchEvents()

const?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list