[Webkit-unassigned] [Bug 77028] percent width includes borders and paddings on CSS tables

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 17:36:25 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77028


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173029|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #16 from Julien Chaffraix <jchaffraix at webkit.org>  2012-11-08 17:38:01 PST ---
(From update of attachment 173029)
View in context: https://bugs.webkit.org/attachment.cgi?id=173029&action=review

I don't need to see the updated patch.

> Source/WebCore/ChangeLog:12
> +        This was already handled for fixed width CSS tables but not for percent
> +        width tables.

The ChangeLog seems stale as you handle any specified length. Also please rename the bug to cover the extended use case (which includes updating the tests).

> LayoutTests/fast/table/css-table-width-with-border-padding.html:86
> +    <!-- For box-sizing: padding-box (not supported) -->

You should probably mention that the results as checking in are wrong: because we don't support box-sizing: padding-box, the results are 100px longer.

You could also check in the expected result. I don't feel strongly about the 2 options (which are equivalent). Filing a bug or commenting on the box-sizing: padding-box change is important in both cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list