[Webkit-unassigned] [Bug 101294] While absolute positioning is put before the first flexitem, flexitems will move to a new line.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101294


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172928|review?                     |review-
               Flag|                            |




--- Comment #12 from Ojan Vafai <ojan at chromium.org>  2012-11-07 22:03:30 PST ---
(From update of attachment 172928)
View in context: https://bugs.webkit.org/attachment.cgi?id=172928&action=review

This patch doesn't seem to apply to tip of tree (see all the bot failures).

> Source/WebCore/ChangeLog:10
> +		If there is an absolutely positioned flex item before other items in a container and the container is set to "-webkit-flex-flow: row wrap", the flex item after the absolutely positioned will move to a new line.
> +		This issue has to do with RenderFlexibleBox::computeNextFlexLine. When determing line breaks, the algorithm sees if 1) the total width exceeds lineBreakLength and 2) whether orderedChildren is non-empty.  But then, if the total width exceeds lineBreakLength and there's only absolutely positioned elemments in orderedChildren then the conditions are met and the algorithm mistakenly breaks the line.
> +		The solution is to see if orderedChildren collects at least a flex item. If it does, break the line.

Please use only spaces and not tabs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.