[Webkit-unassigned] [Bug 101455] webkitpy/layouttests integration test fails if high shards/processes environment variables are used

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 13:10:37 PST 2012


--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2012-11-07 13:12:11 PST ---
The intent of that test is to ensure that we still use only one locked shard by default even if we have more than one child process. We should probably document that with a comment or something :).

So, using --max-locked-shards would defeat the point of the test. I would suggest we mock out/override os.environ in this particular test to preserve the code path.

However, this also points out that we don't have tests ensuring that WEBKIT_TEST_MAX_LOCKED_SHARDS actually does do something, or ensuring that --max-locked-shards actually does the right thing. We should probably add tests for that as well.

I don't think we need to (or should) skip the tests.

Does that help?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list