[Webkit-unassigned] [Bug 101420] Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101420





--- Comment #3 from Remy "Psy" Demarest <rdemarest at apple.com>  2012-11-07 10:50:09 PST ---
(In reply to comment #2)
> (From update of attachment 172697 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172697&action=review
> 
> Nice patch. I did not know about those annotations.
> 
> > Source/WTF/ChangeLog:9
> > +        Defines CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, uses in function declarations.
> 
> Ok, not a native English speaker here. :)
> Should Define and use really take a S? Is the subject implicit or something?

Same here, not a native speaker, but if you take the "patch" as the subject of the sentence, then the S makes sense. Though the second sentence might need a "uses them in function declarations".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.