[Webkit-unassigned] [Bug 98715] [EFL] Enable -Werror for the EFL port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 06:42:21 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=98715





--- Comment #15 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-07 06:43:53 PST ---
(From update of attachment 172650)
View in context: https://bugs.webkit.org/attachment.cgi?id=172650&action=review

>> Source/cmake/WebKitHelpers.cmake:-40
>> -        SET(OLD_COMPILE_FLAGS "-DANOTHER_BRICK_IN_THE -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}")
> 
> -DANOTHER_BRICK_IN_THE -Wall is a long standing joke on the CMake buildsystem, I think it should stay.

I don't see the point in keeping this "joke". It makes the line uselessly longer. If anything it does not look serious.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list