[Webkit-unassigned] [Bug 101349] GStreamer reference handling fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 07:45:52 PST 2012


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #172586|review?                     |review-
               Flag|                            |

--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-11-06 07:47:23 PST ---
(From update of attachment 172586)
View in context: https://bugs.webkit.org/attachment.cgi?id=172586&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:220
> -    GRefPtr<GstPadTemplate> padTemplate = adoptGRef(gst_static_pad_template_get(&srcTemplate));
> +    GRefPtr<GstPadTemplate> padTemplate = adoptGRef(WTF::refGPtr(gst_static_pad_template_get(&srcTemplate)));

I think it would make more sense to simply avoid using adoptGRef here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list