[Webkit-unassigned] [Bug 101193] [EFL][WK2] Add ewk_database_manager APIs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 01:34:05 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101193





--- Comment #5 from Jihye Kang <jye.kang at samsung.com>  2012-11-06 01:35:35 PST ---
(In reply to comment #2)
> (From update of attachment 172452 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172452&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_database_manager.cpp:67
> > +struct Ewk_Database_Origins_Async_Get_Context {
> 
> Can't we use class instead of struct ? As you know, EFL port start to use class for internal usage.

Can I keep this as struct? As Christopher said, it's a callback struct and it is the same style on other codes.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_database_manager.h:69
> > +
> 
> Unneeded line.

Will remove.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_database_manager_private.h:46
> > +    explicit Ewk_Database_Manager(WKDatabaseManagerRef wkDatabaseManagerRef);
> 
> It looks wkDatabaseManagerRef is not meaningful. Generally, WebKit has been omitted parameter name when there is no meaning.

I will remove wk prefix on variable/parameter names.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list