[Webkit-unassigned] [Bug 101241] [EFL] [WK2] Random crash in Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101241





--- Comment #5 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-05 14:18:49 PST ---
(From update of attachment 172381)
View in context: https://bugs.webkit.org/attachment.cgi?id=172381&action=review

>>> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:194
>>> +    Evas_GL_Surface* evasGLSurface() const { return m_evasGLSurface ? m_evasGLSurface->surface() : 0; }
>> 
>> Adding these const is against the latest webkit coding style.
> 
> Wow. 
> Do you have some reference?
> At least style checker didn't complain ;)
> Those "const" mean that method don't change object and optimizer can do something with them. Previously there was single call to those method in function, but now I've added 2nd one, so it is better go give some hint to compiler.

http://lists.webkit.org/pipermail/webkit-dev/2012-October/022576.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.