[Webkit-unassigned] [Bug 101223] [BlackBerry] ImageDiff build clean-up

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 08:39:41 PST 2012


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #172338|review?                     |review-
               Flag|                            |

--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-11-05 08:41:10 PST ---
(From update of attachment 172338)
View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review

Looks good, can be made a bit more robust.

> Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6
> +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff"

It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list