[Webkit-unassigned] [Bug 101006] Text Autosizing: Change m_textAutosizingFontScaleFactor to double type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 05:32:57 PST 2012


--- Comment #12 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-05 05:34:26 PST ---
(In reply to comment #11)
> Julien makes a good point, that the existing APIs in Settings.h are all double-based, but that's because they are all timeouts/durations. When dealing with font sizes WebCore tends to deal exclusively with floats (see RenderStyle.h, FontDescription.h, etc), so it makes sense for Settings::fontScaleFactor to be a float as well.
> So it's probably fine to leave things as they stand before this change, i.e. WK2 API takes a double since they prefer that, but it gets converted to a float when calling the WebCore Settings API. Sorry we didn't think of this earlier!

I am OK with that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list