[Webkit-unassigned] [Bug 101006] Text Autosizing: Change m_textAutosizingFontScaleFactor to double type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 05:22:44 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #171973|commit-queue+               |commit-queue-
               Flag|                            |

--- Comment #10 from Julien Chaffraix <jchaffraix at webkit.org>  2012-11-05 05:24:13 PST ---
(From update of attachment 171973)
View in context: https://bugs.webkit.org/attachment.cgi?id=171973&action=review

Please make this bug block the WK2 implementation (bug 100633).

There is one issue with the change as-is: the WebCore math is still float based which is not great. Because we manipulate fonts, it doesn't make sense to switch to 'double'. We may as well do the conversion at the Settings level (as we are doing now) and let the API take the value they want. 

IMHO this change doesn't add much but as other people may have different views so I won't block the change.

> Source/WebCore/ChangeLog:8
> +        WKPreferences in WK2 prefers to use double than float.

s/than/instead of/? (Note: I am not a native speaker but the use of 'than' here sounds wrong).

> Source/WebCore/ChangeLog:9
> +        Change m_textAutosizingFontScaleFactor to double type for the consistency with WKPreferences.

s/the consistency/consistency/.

> Source/WebCore/ChangeLog:11
> +        No need to test.

Usually you want to explain 'why' you don't add a test. Here is some examples:
* Refactoring, covered by existing tests.
* No change in behavior expected so no test.
* Type change only, no expected change in behavior.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list