[Webkit-unassigned] [Bug 77028] percent width includes borders and paddings on CSS tables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77028





--- Comment #6 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-11-03 06:05:54 PST ---
(In reply to comment #4)
> (From update of attachment 171381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171381&action=review
> 
Thanks for the review Julien. Have uploaded another patch with the changes.

> > Source/WebCore/rendering/RenderTable.cpp:321
> > +    if (isCSSTable && (styleLogicalWidth.isFixed() || styleLogicalWidth.isPercent()) && styleLogicalWidth.isPositive()) {
> 
> Shouldn't *any* specified width be handled in this way? This will fix the issue for percent but other values still have the issue (e.g. viewport relative length).
> 
> We should fix all cases at once by using styleLogicalWidth.isSpecified() instead of just patching our way around.
> 
Yes, the check should indeed be for all specified values. Have made the change.

> > LayoutTests/fast/table/css-table-width-with-border-padding.html:43
> > +    </div>
> 
> This should probably be a check-layout.js (the upside is that it would run faster).
> 
Done.

> > LayoutTests/fast/table/css-table-width-with-border-padding.html:46
> > +</html>
> 
> It would be nice to have some checks against box-sizing values as part of this too. That makes sure we don't break it (which I don't think you do).
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.