[Webkit-unassigned] [Bug 101145] Renamed ...InlineMethods.h files to ...Inlines.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101145





--- Comment #3 from Mark Lam <mark.lam at apple.com>  2012-11-03 01:12:05 PST ---
(In reply to comment #2)
> Attachment 172212 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSObjectRef.cpp'..." exit_code: 1
> Source/JavaScriptCore/heap/MarkStackInlines.h:40:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> Source/JavaScriptCore/heap/MarkStackInlines.h:47:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> Source/JavaScriptCore/runtime/JSValueInlines.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
> Total errors found: 3 in 83 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

These were pre-existing conditions in the files before I renamed them.  The 2 lines in MarkStackInlines.h are just spaces in empty lines.  I will remove them before I commit.

On the other hand, JSValueInlines.h has indentation for all the inline methods in the file.  To fix this, I will have to change the indentation of the entire file.  So, I'll just leave it as is instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.