[Webkit-unassigned] [Bug 88442] run-webkit-tests --reset-results prints out that it resets passing tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88442





--- Comment #12 from Ojan Vafai <ojan at chromium.org>  2012-11-02 11:49:59 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > I'm not understanding something. Whether the test is currently expected to pass or not is irrelevant. But, if it actually did pass in the run that you are trying to reset results, then overwriting the file should be a noop, no?
> 
> On the chromium port, yes. However, if you're using fuzzy pixel diffing, things might be different.

Ah right. Fuzzy diffing is what I wasn't thinking of. I think we *should* always rebaseline passing tests too. We just shouldn't write a file out and print something to stdio if the file we're writing out is the same as the existing one. Is there any downside to doing it this way?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.