[Webkit-unassigned] [Bug 100674] [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100674





--- Comment #22 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-02 06:42:19 PST ---
(From update of attachment 172044)
View in context: https://bugs.webkit.org/attachment.cgi?id=172044&action=review

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:161
> +void EwkViewImpl::initialize()

I don't really like this initialize() method. We were trying to get rid of this initialization in several steps in separate functions.
I guess this could be solved by having a base class shared by EwkViewImplLegacy and EwkViewImpl. This code would then move to the EwkViewImpl constructor.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:250
> +    IntPoint scrollPosition = this->scrollPosition();

I would remove the "this->", we don't usually use it explicitely

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:251
> +    float scaleFactor = this->scaleFactor();

Ditto.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:187
> +    virtual const float scaleFactor() { return m_pageViewportControllerClient->scaleFactor(); }

should probably be a const method, not const return value.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:188
> +    virtual const WebCore::IntPoint scrollPosition() { return m_pageViewportControllerClient->scrollPosition(); }

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.