[Webkit-unassigned] [Bug 100674] [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100674





--- Comment #18 from Yael <yael.aharon.m at gmail.com>  2012-11-02 04:54:40 PST ---
(In reply to comment #17)
> (From update of attachment 171953 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171953&action=review
> 
> Think it's worth creating PageClientImplLegacy rather than EwkViewImplLegacy
> 
I don't agree on that one :) At a high level, being a legacy mode or fixed layout mode is an attribute of the view, not of the page client.

> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:334
> > +{
> 
> Does the view really need to have all these methods, seems the place of this functionality is inside page client
> 
It Qt port, these methods go all the way up to QQuickWebView asnd QQuickWebPage. In my first implementation, I took a shortcut.

> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:187
> > +    virtual float scaleFactor() { return m_pageViewportControllerClient->scaleFactor(); }
> 
> should be const
> 
ok

> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:188
> > +    virtual WebCore::IntPoint scrollPosition() { return m_pageViewportControllerClient->scrollPosition(); }
> 
> same here
ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.