[Webkit-unassigned] [Bug 99801] Web Inspector: [JSC] implement WorkerScriptDebugServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99801





--- Comment #11 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-11-02 01:38:56 PST ---
(In reply to comment #10)
> (From update of attachment 171804 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171804&action=review
> 
> Consider adding a test for the worker debugging functionality. Now that we have support for pure protocol tests (kudos to vivekg) it shouldn't be hard to test worker debugging functionality. See for example the test I recently added for workers: LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html
ok, I'll do it ASAP.

> > Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp:61
> > +    recompileAllJSFunctions(0);
> 
> recompileAllJSFunctions should only be called when the first listener is being added. It seems that we need to fix this in PageSriptDebugServer as well.

Yes, I also find it's a vulnerable part. The problem becomes more obvious when there is a timer in worker: seems inspector cannot distinguish if the JS code is updated or just be executed again by timer. JSC is OK so far just because it doesn’t recompile the js code for timer of worker.  I'm investigating it now.

Thank you for your time, sir.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.