[Webkit-unassigned] [Bug 99588] Use the new forwarder2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 1 09:16:53 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=99588
--- Comment #18 from felipe <felipeg at chromium.org> 2012-11-01 09:18:15 PST ---
(From update of attachment 171471)
View in context: https://bugs.webkit.org/attachment.cgi?id=171471&action=review
>> Tools/ChangeLog:6
>> + "Reviewed by NOBODY (OOPS!)."
>
> nit: no need for the quotes here :).
done
>> Tools/ChangeLog:8
>> + Itâs currently not possible to run the Clank test suite on
>
> Clank?
done
>> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:88
>> +FORWARDER_TIMEOUT_SECS = 30
>
> nit: Should we place this line after line 84 for additional clarity?
done
>> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:451
>> + _TIMEOUT = 3
>
> nit: Other constants don't have the underscore prefix, I'd prefer if we could stay consistent here.
done
>> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:455
>> + self._port = android_port
>
> self._port is not used elsewhere in this class.
done
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list