[Webkit-unassigned] [Bug 100851] [V8] use toV8Fast in all relevant Node getters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 08:29:38 PDT 2012


--- Comment #8 from Kentaro Hara <haraken at chromium.org>  2012-11-01 08:31:00 PST ---
(In reply to comment #7)
> View in context: https://bugs.webkit.org/attachment.cgi?id=171854&action=review
> > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:545
> > +inline v8::Handle<v8::Value> toV8Fast(${nativeType}* node, const v8::AccessorInfo& info, Node* holder)
> It's unfortunate that we now have two copies of this function definition.  Maybe we could make a helper "generate" function to share the code?

Or can we just generate nothing so that the virtualized Node::toV8Fast() is called ?

dcarney: Sorry for setting my r? by mistake... please reset it:)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list