[Webkit-unassigned] [Bug 100829] [EFL] CMake shows ENABLE_3D_RENDERING and ENABLE_WEBGL is still OFF when AC is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100829


Raphael Kubo da Costa (rakuco) <rakuco at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paroga at paroga.com




--- Comment #4 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-11-01 06:39:29 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 171598 [details] [details])
> > Simply moving the call to WEBKIT_OPTION_END() to the end of the file in OptionsEfl.cmake should solve the problem in a cleaner way.
> 
> I tried, but it doesn't work.

That's probably because of the interaction between normal variables and cache variables in CMake.

SET(ENABLE_WEBGL 1) in OptionsEfl.cmake sets a normal variable, and later the call to OPTION(ENABLE_WEBGL ...) will set a cache variable with the same name and remove the original normal variable.

I think the cleanest solution here is to move the call to WEBKIT_OPTION_END() to the end of OptionEfl.cmake and modify the macro so that the initial value it uses in the OPTION() call is the value of the variable itself if it is defined, and the initial value otherwise. This would still require you to clean up your cache nonetheless, as CMake by default won't change the options you already have in your cache when you call a command such as OPTION().

Patrick, what do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.