[Webkit-unassigned] [Bug 100923] Free GL resources allocated by GraphicsContext3DEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100923





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-01 04:18:21 PST ---
(From update of attachment 171784)
View in context: https://bugs.webkit.org/attachment.cgi?id=171784&action=review

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:156
> +    if (m_renderStyle == RenderToCurrentGLContext || !m_private)
> +        return;
> +    makeContextCurrent();

We usually add a newline after return statements and before if/for/while etc sentenses unless the code is very relevant to it, like declaration of iterators

So newline after return here. I also think this return needs a comment ontop of the if.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:158
> +    glDeleteTextures(1, &m_texture);
> +    if (m_attrs.antialias) {

newline before if here

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:161
> +        if (m_attrs.stencil || m_attrs.depth)
> +            glDeleteRenderbuffers(1, &m_multisampleDepthStencilBuffer);

Newline before and after

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:166
> +            glDeleteRenderbuffers(1, &m_depthBuffer);

newline after this

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.