[Webkit-unassigned] [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103513





--- Comment #35 from Antoine Quint <graouts at apple.com>  2012-11-30 15:11:14 PST ---
(In reply to comment #33)
> (From update of attachment 176977 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176977&action=review
> 
> Overall, it looks good, I think it is Ok to proceed with the test.
> 
> > Source/WebCore/inspector/Inspector.json:3264
> > +                "hidden": true
> 
> nit: here and below, no need to hide methods of the hidden domain.

You're right, I should have cleaned that up when I made the entire domain hidden. Will make that change.

> > Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:218
> > +    const RenderLayer* renderLayer = m_idToLayer.get(layerId);
> 
> this can be 0 and you should return an error for this.

Right, I'll make the following change:

    // Send an error if there is no such registered layer id.
    if (!renderLayer) {
        *errorString = "Could not find a bound layer for the provided id";
        return;
    }

> > Source/WebCore/rendering/RenderLayerCompositor.cpp:514
> > +    InspectorInstrumentation::layerTreeDidChange(this->page());
> 
> just page() ?
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:520
> > +    InspectorInstrumentation::renderLayerDestroyed(this->page(), renderLayer);
> 
> ditto

I was keeping in style with several this->page() in this file. I'm not sure what's best here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.