[Webkit-unassigned] [Bug 103335] [CSS Grid Layout] Support all specified breadth size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103335


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176754|0                           |1
        is obsolete|                            |




--- Comment #7 from Xan Lopez <xan.lopez at gmail.com>  2012-11-30 10:04:01 PST ---
Created an attachment (id=176987)
 --> (https://bugs.webkit.org/attachment.cgi?id=176987&action=review)
breadth-types.diff

OK, another patch. I think I'm making progress but not quite there yet.

- Using zoomAdjustedPixelValueForLength (note the ForLength) now in valueForGridTrackBreadth. This seems to give proper results almost everywhere, and allows us to drop the special case for Percent (so only special case for Auto remains).
- Made the changes requested to RenderGrid. The two testcases you mention (fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html and fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html) indeed improved, but still won't work 100%. I'll attach the diffs after.
- The complex calc expressions are still not working, we went back again to no result in the dump. Not sure if I'm not getting what the text should look like here, though.
- Moved the font setting just to the EM class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.