[Webkit-unassigned] [Bug 103605] [CMake] Unify coding style for CMake files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103605





--- Comment #9 from Patrick R. Gansterer <paroga at paroga.com>  2012-11-30 01:17:17 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > > 2.2 Place spaces between function and macro statements and their parentheses. MACRO (), ENDMACRO (), FUNCTION (), ENDFUNCTION (). Same as 2.1
> > I have no strong opinion on this, but if we say that a macro/function is something like a macro/function/method in C/C++, I think that no space would meet the WebKit C/C++ coding style more.
> Okay for me, +1.
> 
> > > 3. Uppercase when call macros and functions. ADD_EXECUTABLE() not add_executable(), SET() not set(). (Referred cmake 2.8 modules) 
> > AFAIK all lowercase is the "new" CMake style. If you look at new code added to the CMake repository, it is usually lowercase. Also the documentation at http://www.cmake.org/cmake/help/v2.8.10/cmake.html uses lowercase.
> Okay for me, +1.
> 
> > Any ideas about adding a CMake codeing style checker? Or at least a well know place to put this new rules, so we can refer to it, when seeing violations?
> Good suggestion and I think the checker should do inside  Tools/Script. Can I do that in a separately?
Of course!

> As for the document, any possible to add CMake part under http://www.webkit.org/coding/coding-style.html? (I do not think I have permission to do that).
The websites live at http://trac.webkit.org/browser/trunk/Websites, but I'm not sure if it's the correct place, since there are e.g. no JavaScript rules too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.