[Webkit-unassigned] [Bug 103592] [BlackBerry] DRT - crashed on WebCore::SearchFieldCancelButtonElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103592


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176687|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Kent Tamura <tkent at chromium.org>  2012-11-29 05:27:50 PST ---
(From update of attachment 176687)
View in context: https://bugs.webkit.org/attachment.cgi?id=176687&action=review

> Source/WebCore/ChangeLog:19
> +        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
> +        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

SearchFieldResultsButtonElement::defaultEventHandler should have a similar change.

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:200
> -    if (input->disabled() || input->readOnly()) {
> +    if (!input || input->disabled() || input->readOnly()) {

You have to update SearchFieldCancelButtonElement::willRespondToMouseClickEvents too.

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:285
> -    if (input->disabled() || input->readOnly()) {
> +    if (!input || input->disabled() || input->readOnly()) {

You have to update InputFieldSpeechButtonElement::willRespondToMouseClickEvents too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.