[Webkit-unassigned] [Bug 103610] [EFL] libwebcore_efl.a fail to link when enable webgl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103610





--- Comment #3 from Halton Huo <halton.huo at gmail.com>  2012-11-29 02:27:22 PST ---
(In reply to comment #2)
> (From update of attachment 176670 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176670&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        bin/DumpRenderTree
> 
> What is this ?
This link error happens when link libwebcore_efl to DumpRenderTree, I just check whether this binary generated and can be run with my patch. I'll update the comment with more specific word.

> 
> > Source/WebCore/PlatformEfl.cmake:302
> > +    "-lXcomposite -lXrender"
> 
> IMO, it would be good if you link this libraries from FindXXX.cmake file or macro.
I do this because WebCore.pri add those two libs directly.
226 use?(GRAPHICS_SURFACE) {
227     mac: LIBS += -framework IOSurface -framework CoreFoundation
228     linux-*: {
229         LIBS += -lXcomposite -lXrender
230         CONFIG *= x11
231     }
232 }

After going through the FindX11.cmake, I found X11_Xcomposite_LIB and X11_Xrandr_LIB are defined, I'll use them and update the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.