[Webkit-unassigned] [Bug 103581] New: run-perf-tests --chromium-android should not require adb in my path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103581

           Summary: run-perf-tests --chromium-android should not require
                    adb in my path
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, dpranke at chromium.org,
                    peter at chromium.org


run-perf-tests --chromium-android should not require adb in my path

If you don't have adb in your path it barfs:

Running 1 tests
Traceback (most recent call last):
  File "/src/WebKit/Tools/Scripts/run-perf-tests", line 40, in <module>
    sys.exit(PerfTestsRunner().run())
  File "/src/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 187, in run
    unexpected = self._run_tests_set(sorted(list(tests), key=lambda test: test.test_name()), self._port)
  File "/src/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 318, in _run_tests_set
    driver = port.create_driver(worker_number=0, no_timeout=True)
  File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 257, in create_driver
    no_timeout=True)
  File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 340, in __init__
    self._device_serial = port._get_device_serial(worker_number)
  File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 322, in _get_device_serial
    devices = self._get_devices()
  File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 315, in _get_devices
    result = self._executive.run_command(['adb', 'devices'], error_handler=self._executive.ignore_error)
  File "/src/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 405, in run_command
    close_fds=self._should_close_fds())
  File "/src/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 461, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
OSError: [Errno 2] No such file or directory
Exception AttributeError: "'ChromiumAndroidDriver' object has no attribute '_device_serial'" in <bound method ChromiumAndroidDriver.__del__ of <webkitpy.layout_tests.port.chromium_android.ChromiumAndroidDriver object at 0x1198150>> ignored


run-webkit-tests --chromium-android barfs as well, probably for the same reason (it just barfs before logging is set up):

%run-webkit-tests --chromium-android

OSError raised: [Errno 2] No such file or directory
No handlers could be found for logger "__main__"
Failed to execute Tools/Scripts/new-run-webkit-tests at /src/WebKit/Tools/Scripts/run-webkit-tests line 126.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.