[Webkit-unassigned] [Bug 101192] [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 06:01:15 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101192





--- Comment #21 from Adam Barth <abarth at webkit.org>  2012-11-28 06:03:27 PST ---
(From update of attachment 176456)
View in context: https://bugs.webkit.org/attachment.cgi?id=176456&action=review

> Source/WebKit/chromium/public/WebSettings.h:-104
> -    virtual void setExperimentalCSSRegionsEnabled(bool) = 0;

I suspect the problem is that you're trying to change this public API.  What you should do instead is move this function to the bottom of the interface and make it a no-op.  After this patch lands and Chromium's webkit_rev is increased, you can remove any callers in Chromium.  Once the Chromium callers are gone and WebKit's chromium_rev is increased, you can remove the deprecated API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list