[Webkit-unassigned] [Bug 101857] Updating mouse cursor on style changes without emitting fake mousemove event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101857





--- Comment #30 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2012-11-28 05:56:00 PST ---
(In reply to comment #29)
> (In reply to comment #28)
> > (In reply to comment #26)
> > > (In reply to comment #25)
> > > > What does it take to get a review or at least a comment?
> > > > It's not a complicated patch..
> > > > I don't get it - if patches are welcome, why let a bug fix lay around for weeks?
> > > 
> > > I think it looks fine. There are rooms for improvement, but they can come later, but you do need pass the tests on Mac.
> > 
> > Alternatively you add your failing test to LayoutTests/platform/mac/TestExpectations and open a bug on it failing.
> 
> Sounds like a plan, since I have no access to a Mac to investigate. It might have something to do with eventSender implementation, but wouldn't be fun to debug without a test machine.

It never is. If it had been a pre-existing test you would have to though, but since it is a new test, you are allowed a bit more freedom.

Btw, besides only doing this when necessary, the other improvement that could be done is not to construct a PlatformMouseEvent in updateCursor since you are not sending it anyway, but that would require changing the API of the selectCursor method, so it can wait for another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.