[Webkit-unassigned] [Bug 103220] [GTK] Build with LevelDB when IndexedDB is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103220





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-11-27 00:16:54 PST ---
(From update of attachment 175938)
View in context: https://bugs.webkit.org/attachment.cgi?id=175938&action=review

Thanks for the patch! I've some doubts about the jhbuild moduleset changes and the implications of enabling indexdb.

> Source/WebCore/ChangeLog:8
> +        Tests: storage/indexeddb/*

Shouldn't we unskip them? Have you checked all indexdb tests actually pass?

> Tools/ChangeLog:9
> +        * gtk/jhbuild.modules:
> +        * gtk/patches/leveldb-1.6.0-make-install.patch: Added.

I think you should explain here why we need to build leveldb in our jhbuild, and why it requires a patch. Do different versions of leveldb give different results of layout tests? would it be possible to run the tests with the leveldb installed by the distro?

> Tools/gtk/jhbuild.modules:23
> +      <dep package="leveldb"/>

This means we will always build leveldb even when indexdb is not enabled. I think there's no easy way to avoid it, so I guess it would be better to add to the moduleset dependencies that need to be built always and require a particular version to get the same tests results.

> configure.ac:1030
> +if test "$enable_indexed_database" = "yes"; then
> +    PKG_CHECK_MODULES([LEVELDB], [leveldb])
> +    AC_SUBST([LEVELDB_CFLAGS])
> +    AC_SUBST([LEVELDB_LIBS])
> +fi

This depends on a patch applied to leveldb by our jhbuild which means that it will always fail when not using the internal jhbuild + build-webkit even if leveldb is installed. I think you should use AC_SEARCH_LIBS() when PKG_CHECK_MODULES() fails to find the library.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.