[Webkit-unassigned] [Bug 93646] Refactor V8 bindings to allow content scripts to access subframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93646





--- Comment #13 from Dan Carney <dcarney at google.com>  2012-11-26 09:47:04 PST ---
(In reply to comment #12)
> That's great!  I will study the patch carefully.
> 
> Does this mean http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp#L85 is now called multiple times per DOMWrapperWorld, based on the number of Frames that the world gets booted up in?  If you've already gone to sleep, I can puzzle that out for myself.

it's pretty early to go to sleep. i'll explain:

i've avoided dealing with the types of worlds that have called makeContextWeak in this patch, so they don't have cross frame access yet.  I'll deal with that in a different patch. I wanted to confer with you on that first. We have 2 options:

get rid of the weak contexts which could mean a lot more mem consumption for whatever actually uses them

do a complicated thing where the a new hidden object in javascript that represents the DOMWrapperWorld has a weak handle on the context and the context a weak handle on the world js object so that they all die at once

I'm inclined to do the second, but it would be a lot easier just to remove a few lines of code than do a bunch of v8 api magic to make this work

wdyt?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.